-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for drift between .template files and generated files #13
Conversation
(checkout cleanup step should take care of it... in theory)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial style pass
Co-authored-by: Ben Frankel <[email protected]>
Co-authored-by: Ben Frankel <[email protected]>
Co-authored-by: Ben Frankel <[email protected]>
Co-authored-by: Ben Frankel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name:
suggestions aren't hard suggestions. If you have a better idea for them then that's good too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually just remembered another thing. We'll need to exclude ci-generate.yaml
via cargo-generate.toml
.
Ooof. Roll on a really solid way to work with GHA locally, the constant iteration is annoying 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... it just takes so long.
This:
edit: doesn't really close 5 :)
This approach should also work for
bevy_quickstart
, we just need to provide all the template placeholder values with https://cargo-generate.github.io/cargo-generate/templates/template_defined_placeholders.html#--define-or--d-flag.